Add test for ImageXpress transmitted light #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imagejan
force-pushed
the
channel_metadata
branch
2 times, most recently
from
ca8cbf6 to
796df64
Compare
With numpy 2.0.0, we get errors like:
ValueError: numpy.dtype size changed, may indicate binary incompatibility.
Expected 96 from C header, got 88 from PyObject
When using transmitted light acquisition, the "wavelength" metadata gets set to "0.0". While fix ChannelMetadata to account for this, we also disallow 'str' to make behavior consistent between Windows and Linux. (Previously, we got 0.0 [float] on Linux and "0.0" [str] on Windows.)
imagejan
force-pushed
the
channel_metadata
branch
from
796df64 to
a42892e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using transmitted light acquisition, the "wavelength" metadata gets set to "0.0".
While fixing
ChannelMetadatato account for this, we also disallowstrto make behavior consistent between Windows and Linux. (Previously, we got0.0[float] on Linux and"0.0"[str] on Windows.)