Skip to content

Commit

Permalink
[2] Track repo rule label attributes after the first non-existent one
Browse files Browse the repository at this point in the history
Even with this commit, the fact that a particular label in a repository
rule's label attributes does not resolve to a regular file is not
tracked, which means that there is still a potential for incorrect
incremental fetches.

Work towards bazelbuild#13441
  • Loading branch information
fmeum committed May 9, 2023
1 parent 9a1e0cf commit 97c9121
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/test/shell/bazel/external_integration_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2461,7 +2461,7 @@ EOF

mkdir main
cd main
cat > foo.bzl <<'EOF'
cat > foo.bzl <<EOF
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
def foo():
Expand All @@ -2471,7 +2471,7 @@ def foo():
build_file = "@b//:a.BUILD",
)
EOF
cat > bar.bzl <<'EOF'
cat > bar.bzl <<EOF
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
def bar():
Expand All @@ -2493,7 +2493,7 @@ EOF
touch BUILD

bazel build //... > "${TEST_log}" 2>&1 && fail "expected failure" || :
inplace-sed -e 's?$(pwd)/?PWD/?g' "${TEST_log}"
inplace-sed -e "s?$(pwd)/?PWD/?g" "${TEST_log}"

expect_not_log '[iI]nternal [eE]rror'
expect_not_log 'IllegalStateException'
Expand Down

0 comments on commit 97c9121

Please sign in to comment.