forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of rust-lang#124580 - gurry:124556-suggest-remove-tuple-…
…field, r=jackh726 Suggest removing unused tuple fields if they are the last fields Fixes rust-lang#124556 We now check if dead/unused fields are the last fields of the tuple and suggest their removal instead of suggesting them to be changed to `()`.
- Loading branch information
Showing
5 changed files
with
109 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,40 @@ | ||
error: field `1` is never read | ||
--> $DIR/tuple-struct-field.rs:8:26 | ||
error: fields `1`, `2`, `3`, and `4` are never read | ||
--> $DIR/tuple-struct-field.rs:8:28 | ||
| | ||
LL | struct SingleUnused(i32, [u8; LEN], String); | ||
| ------------ ^^^^^^^^^ | ||
LL | struct UnusedAtTheEnd(i32, f32, [u8; LEN], String, u8); | ||
| -------------- ^^^ ^^^^^^^^^ ^^^^^^ ^^ | ||
| | | ||
| field in this struct | ||
| fields in this struct | ||
| | ||
= help: consider removing these fields | ||
note: the lint level is defined here | ||
--> $DIR/tuple-struct-field.rs:1:9 | ||
| | ||
LL | #![deny(dead_code)] | ||
| ^^^^^^^^^ | ||
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | ||
|
||
error: field `0` is never read | ||
--> $DIR/tuple-struct-field.rs:13:27 | ||
| | ||
LL | struct UnusedJustOneField(i32); | ||
| ------------------ ^^^ | ||
| | | ||
| field in this struct | ||
| | ||
LL | struct SingleUnused(i32, (), String); | ||
| ~~ | ||
= help: consider removing this field | ||
|
||
error: fields `0`, `1`, `2`, and `3` are never read | ||
--> $DIR/tuple-struct-field.rs:13:23 | ||
error: fields `1`, `2`, and `4` are never read | ||
--> $DIR/tuple-struct-field.rs:18:31 | ||
| | ||
LL | struct MultipleUnused(i32, f32, String, u8); | ||
| -------------- ^^^ ^^^ ^^^^^^ ^^ | ||
LL | struct UnusedInTheMiddle(i32, f32, String, u8, u32); | ||
| ----------------- ^^^ ^^^^^^ ^^^ | ||
| | | ||
| fields in this struct | ||
| | ||
help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields | ||
| | ||
LL | struct MultipleUnused((), (), (), ()); | ||
| ~~ ~~ ~~ ~~ | ||
LL | struct UnusedInTheMiddle(i32, (), (), u8, ()); | ||
| ~~ ~~ ~~ | ||
|
||
error: aborting due to 2 previous errors | ||
error: aborting due to 3 previous errors | ||
|