Add support to parse request data objects #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmckeogh
reviewed
Jun 11, 2024
usb-pd/src/messages/pdo.rs
Outdated
| si::u16::ElectricPotential::new::<_20millivolts>(self.raw_output_voltage()) | ||
| } | ||
|
|
||
| pub fn operating_current_ma(&self) -> si::u16::ElectricCurrent { |
There was a problem hiding this comment.
_ma suffix not needed given the return type?
There was a problem hiding this comment.
done (and the other comment as well) - Looks like i missed some changes when an earlier draft on the si changes commits
usb-pd/src/messages/pdo.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl FixedVariableRequestDataObject { | ||
| pub fn to_bytes(&self, buf: &mut [u8]) { | ||
| LittleEndian::write_u32(buf, self.0); | ||
| } | ||
|
|
||
| pub fn operating_current_ma(&self) -> u16 { |
There was a problem hiding this comment.
Could this and max_operating_current_ma use SI units in the return type?
Similar to what was done on the other pdo packets add utility functions to get the real watts/power values from the raw values in the packet.
Add parser for Adjustable Voltage Supply requests; Also add an enum covering the various supported request objects, similar to th PDO enum.
To be able to parse Request messages some state needs to be kept as the request objects don't indicate their type only their position as per the last source capabilities. Add a simple trait for maintaining pdo state that current just translates between the object position of the request type and the matching type. This trait is for SourceCapabilities (potentially wrapped in an Option) which allows implementations to maintain state simply by saving the last SourceCapabilities message.
sjoerdsimons
force-pushed
the
parse-requests
branch
from
53d488b
to
96948b9
Compare
|
@sjoerdsimons Thanks for your work! |
okhsunrog
added a commit
to okhsunrog/usb-pd-rs
that referenced
this pull request
Jun 18, 2024
Add support to parse request data objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.