-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set axiom handling #151
Merged
Merged
Set axiom handling #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Fischman
force-pushed
the
bounded-refactor
branch
from
August 25, 2023 02:59
f357c8a
to
3c59745
Compare
Signed-off-by: Alex Fischman <[email protected]>
Current in a debugging state. This doesn't run on consensus_forall yet because of and-or alternations. Signed-off-by: Alex Fischman <[email protected]>
I had to edit consensus_forall because rets.rs no longer supports nested non-bool-returning relations. Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Alex-Fischman
force-pushed
the
set-axiom-handling
branch
from
August 25, 2023 03:15
76c404e
to
0155819
Compare
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
tchajed
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one comment on something that looks like a logic bug.
Signed-off-by: Alex Fischman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses BDDs to generate initial states and does partial evaluation of post states to prove mutable axioms. It also completely changes non-boolean-relation translation to make it possible to do partial evaluation. I think that it should be merged, but it's currently blocked on merging
bounded-refactor
.It's also worth mentioning that it slightly changes the
consensus_forall
example, because the version ofrets.rs
that it implements can't handle nested non-boolean-returning relations.