Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set axiom handling #151

Merged
merged 9 commits into from
Aug 25, 2023
Merged

Set axiom handling #151

merged 9 commits into from
Aug 25, 2023

Conversation

Alex-Fischman
Copy link
Collaborator

@Alex-Fischman Alex-Fischman commented Aug 10, 2023

This PR uses BDDs to generate initial states and does partial evaluation of post states to prove mutable axioms. It also completely changes non-boolean-relation translation to make it possible to do partial evaluation. I think that it should be merged, but it's currently blocked on merging bounded-refactor.

It's also worth mentioning that it slightly changes the consensus_forall example, because the version of rets.rs that it implements can't handle nested non-boolean-returning relations.

@Alex-Fischman Alex-Fischman changed the base branch from main to bounded-refactor August 11, 2023 18:15
Base automatically changed from bounded-refactor to main August 25, 2023 03:14
Current in a debugging state. This doesn't run on consensus_forall yet because of and-or alternations.

Signed-off-by: Alex Fischman <[email protected]>
I had to edit consensus_forall because rets.rs no longer supports nested non-bool-returning relations.

Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
@Alex-Fischman Alex-Fischman marked this pull request as ready for review August 25, 2023 03:16
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Copy link
Collaborator

@tchajed tchajed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one comment on something that looks like a logic bug.

bounded/src/set.rs Outdated Show resolved Hide resolved
@tchajed tchajed enabled auto-merge August 25, 2023 18:06
@tchajed tchajed added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit fe52f17 Aug 25, 2023
2 checks passed
@tchajed tchajed deleted the set-axiom-handling branch August 25, 2023 18:21
@Alex-Fischman Alex-Fischman restored the set-axiom-handling branch December 6, 2023 07:00
@Alex-Fischman Alex-Fischman deleted the set-axiom-handling branch December 6, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants