Symmetry breaking fingerprinting #150
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Signed-off-by: Alex Fischman <[email protected]>
Alex-Fischman
force-pushed
the
symmetry-breaking-add-all
branch
from
26f23cd
to
759c7bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is much much slower than the symmetry breaking branch that it's built on top of, and should not be merged until it both can run at least half as quickly as
symmetry-breaking-add-alland uses half as much space as the currentseenstates set.This branch uses a fingerprinting method to determine when two states are isomorphic to each other. The current fingerprinting algorithm is very slow, and can certainly be improved; however, I don't think it'll ever be as fast as the
add-allversion, and I have doubts that it'll ever catch up enough to be worth using.