Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests in CI and use go 1.22 #18

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Run unit tests in CI and use go 1.22 #18

wants to merge 4 commits into from

Conversation

eapolinario
Copy link

@eapolinario eapolinario commented Dec 17, 2024 •
edited
Loading

We have a few unit tests, so let's make that those run in CI on PRs and merges to master.

edit: I also bumped the version to match the one in the main flyte repo since unit tests were failing to run in CI due to:

go: downloading golang.org/x/text v0.16.0
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/curve25519/curve25519.go:13:8: package crypto/ecdh is not in GOROOT (/opt/hostedtoolcache/go/1.18.10/x64/src/crypto/ecdh)
Error: Process completed with exit code 1.

@eapolinario eapolinario changed the title Run unit tests in CI Run unit tests in CI and use go 1.22 Dec 17, 2024
@eapolinario eapolinario mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eapolinario