Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fixed logger levels in viper #87

Merged
merged 1 commit into from
Jun 13, 2021
Merged

Fixed logger levels in viper #87

merged 1 commit into from
Jun 13, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Jun 12, 2021

TL;DR

  • Fixed logger level in viper package

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #87 (64c479d) into master (92b25c6) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   65.49%   65.45%   -0.05%     
==========================================
  Files          59       59              
  Lines        2275     2275              
==========================================
- Hits         1490     1489       -1     
- Misses        642      643       +1     
  Partials      143      143              
Flag Coverage Δ
unittests 65.45% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/viper/viper.go 8.02% <0.00%> (ø)
sets/generic_set.go 93.33% <0.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b25c6...64c479d. Read the comment docs.

@yindia yindia force-pushed the fix/viper-logger branch from 53ea80d to 64c479d Compare June 12, 2021 07:47
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yindia yindia merged commit a83ff3d into master Jun 13, 2021
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants