This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Generate mocks for data storage for use in tests #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
requested review from
EngHabu,
kumare3 and
wild-endeavor
as code owners
katrogan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 72.10% 72.10%
=======================================
Files 57 57
Lines 1975 1975
=======================================
Hits 1424 1424
Misses 412 412
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
pmahindrakar-oss
approved these changes
Apr 16, 2021
EngHabu
approved these changes
Apr 16, 2021
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan [email protected]
TL;DR
Generate mock for data storage for use in tests. Required to satisfy flyteorg/flytepropeller#254 (comment)
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA