This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 72.27% 70.41% -1.87%
==========================================
Files 57 57
Lines 2424 1967 -457
==========================================
- Hits 1752 1385 -367
+ Misses 533 444 -89
+ Partials 139 138 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
EngHabu
added a commit
that referenced
this pull request
Mar 22, 2021
* Update CI post migration * Migrate to github workflows * length check * debug * Avoid installing pflags from repo * Update deps * update go action * try import path * update protos * set checkout depth * cleanup * typo in master wf Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
added a commit
that referenced
this pull request
Mar 22, 2021
* Update CI post migration * Migrate to github workflows * length check * debug * Avoid installing pflags from repo * Update deps * update go action * try import path * update protos * set checkout depth * cleanup * typo in master wf Signed-off-by: Haytham Abuelfutuh <[email protected]>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
May 11, 2021
* Update CI post migration * Migrate to github workflows * length check * debug * Avoid installing pflags from repo * Update deps * update go action * try import path * update protos * set checkout depth * cleanup * typo in master wf Signed-off-by: Haytham Abuelfutuh <[email protected]>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
May 13, 2021
* Update CI post migration * Migrate to github workflows * length check * debug * Avoid installing pflags from repo * Update deps * update go action * try import path * update protos * set checkout depth * cleanup * typo in master wf Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]>
EngHabu
added a commit
that referenced
this pull request
May 18, 2021
* Update CI post migration (#68) * Update CI post migration * Migrate to github workflows * length check * debug * Avoid installing pflags from repo * Update deps * update go action * try import path * update protos * set checkout depth * cleanup * typo in master wf Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Disable scoope publishing Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Rename (#73) * first pass at updating references * update module name * update boilerplate mod * remove version * mor * mockery * maybe * mor * replace replace * trying something * other Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Remove dependency on lyft/api (#71) Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Always try to create a bucket when loading a container (#76) Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Update create container if not exists logic (#77) Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Support binding pflags to default variable fields Support Map Types now that viper does Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added some coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> * Reverting to go 1.16 Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed unit test Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: brucearctor <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Katrina Rogan <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Update CI post migration * Migrate to github workflows * length check * debug * Avoid installing pflags from repo * Update deps * update go action * try import path * update protos * set checkout depth * cleanup * typo in master wf
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Update CI post migration (#68) * Update CI post migration * Migrate to github workflows * length check * debug * Avoid installing pflags from repo * Update deps * update go action * try import path * update protos * set checkout depth * cleanup * typo in master wf Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Disable scoope publishing Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Rename (#73) * first pass at updating references * update module name * update boilerplate mod * remove version * mor * mockery * maybe * mor * replace replace * trying something * other Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Remove dependency on lyft/api (#71) Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Always try to create a bucket when loading a container (#76) Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Update create container if not exists logic (#77) Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Support binding pflags to default variable fields Support Map Types now that viper does Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added some coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> * Reverting to go 1.16 Signed-off-by: Prafulla Mahindrakar <[email protected]> * Fixed unit test Signed-off-by: Prafulla Mahindrakar <[email protected]> * Added more coverage Signed-off-by: Prafulla Mahindrakar <[email protected]> Co-authored-by: brucearctor <[email protected]> Co-authored-by: Ketan Umare <[email protected]> Co-authored-by: Katrina Rogan <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Update CI Settings after migrating to flyteorg.
Type
flyteorg/flyte#688