Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update CI post migration #68

Merged
merged 12 commits into from
Jan 31, 2021
Merged

Update CI post migration #68

merged 12 commits into from
Jan 31, 2021

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Jan 31, 2021

TL;DR

Update CI Settings after migrating to flyteorg.

Type

  • Bug Fix
  • Feature
  • Plugin

flyteorg/flyte#688

@EngHabu EngHabu requested a review from kumare3 as a code owner January 31, 2021 12:27
@codecov-io
Copy link

codecov-io commented Jan 31, 2021

Codecov Report

Merging #68 (04d1cae) into master (519a271) will decrease coverage by 1.86%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   72.27%   70.41%   -1.87%     
==========================================
  Files          57       57              
  Lines        2424     1967     -457     
==========================================
- Hits         1752     1385     -367     
+ Misses        533      444      -89     
+ Partials      139      138       -1     
Flag Coverage Δ
unittests 70.41% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/pflags/api/generator.go 69.65% <25.00%> (-4.06%) ⬇️
config/files/finder.go 54.16% <0.00%> (-11.46%) ⬇️
storage/storage.go 60.00% <0.00%> (-11.43%) ⬇️
pbhash/pbhash.go 50.00% <0.00%> (-10.00%) ⬇️
storage/config.go 50.00% <0.00%> (-10.00%) ⬇️
promutils/labeled/gauge.go 38.29% <0.00%> (-8.98%) ⬇️
logger/config.go 42.85% <0.00%> (-7.15%) ⬇️
storage/url_path.go 46.66% <0.00%> (-6.28%) ⬇️
promutils/labeled/counter.go 34.78% <0.00%> (-5.96%) ⬇️
utils/marshal_utils.go 51.72% <0.00%> (-5.86%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 519a271...04d1cae. Read the comment docs.

@EngHabu EngHabu merged commit 5cf5567 into master Jan 31, 2021
EngHabu added a commit that referenced this pull request Mar 22, 2021
* Update CI post migration

* Migrate to github workflows

* length check

* debug

* Avoid installing pflags from repo

* Update deps

* update go action

* try import path

* update protos

* set checkout depth

* cleanup

* typo in master wf

Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu added a commit that referenced this pull request Mar 22, 2021
* Update CI post migration

* Migrate to github workflows

* length check

* debug

* Avoid installing pflags from repo

* Update deps

* update go action

* try import path

* update protos

* set checkout depth

* cleanup

* typo in master wf

Signed-off-by: Haytham Abuelfutuh <[email protected]>
pmahindrakar-oss pushed a commit that referenced this pull request May 11, 2021
* Update CI post migration

* Migrate to github workflows

* length check

* debug

* Avoid installing pflags from repo

* Update deps

* update go action

* try import path

* update protos

* set checkout depth

* cleanup

* typo in master wf

Signed-off-by: Haytham Abuelfutuh <[email protected]>
pmahindrakar-oss pushed a commit that referenced this pull request May 13, 2021
* Update CI post migration

* Migrate to github workflows

* length check

* debug

* Avoid installing pflags from repo

* Update deps

* update go action

* try import path

* update protos

* set checkout depth

* cleanup

* typo in master wf

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
EngHabu added a commit that referenced this pull request May 18, 2021
* Update CI post migration (#68)

* Update CI post migration

* Migrate to github workflows

* length check

* debug

* Avoid installing pflags from repo

* Update deps

* update go action

* try import path

* update protos

* set checkout depth

* cleanup

* typo in master wf

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Disable scoope publishing

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Rename (#73)

* first pass at updating references

* update module name

* update boilerplate mod

* remove version

* mor

* mockery

* maybe

* mor

* replace replace

* trying something

* other

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Remove dependency on lyft/api (#71)

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Always try to create a bucket when loading a container (#76)

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Update create container if not exists logic (#77)

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Support binding pflags to default variable fields
Support Map Types now that viper does

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Added some coverage

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Reverting to go 1.16

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Fixed unit test

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Added more coverage

Signed-off-by: Prafulla Mahindrakar <[email protected]>

Co-authored-by: brucearctor <[email protected]>
Co-authored-by: Ketan Umare <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: Prafulla Mahindrakar <[email protected]>
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Update CI post migration

* Migrate to github workflows

* length check

* debug

* Avoid installing pflags from repo

* Update deps

* update go action

* try import path

* update protos

* set checkout depth

* cleanup

* typo in master wf
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Update CI post migration (#68)

* Update CI post migration

* Migrate to github workflows

* length check

* debug

* Avoid installing pflags from repo

* Update deps

* update go action

* try import path

* update protos

* set checkout depth

* cleanup

* typo in master wf

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Disable scoope publishing

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Rename (#73)

* first pass at updating references

* update module name

* update boilerplate mod

* remove version

* mor

* mockery

* maybe

* mor

* replace replace

* trying something

* other

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Remove dependency on lyft/api (#71)

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Always try to create a bucket when loading a container (#76)

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Update create container if not exists logic (#77)

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Support binding pflags to default variable fields
Support Map Types now that viper does

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Added some coverage

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Reverting to go 1.16

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Fixed unit test

Signed-off-by: Prafulla Mahindrakar <[email protected]>

* Added more coverage

Signed-off-by: Prafulla Mahindrakar <[email protected]>

Co-authored-by: brucearctor <[email protected]>
Co-authored-by: Ketan Umare <[email protected]>
Co-authored-by: Katrina Rogan <[email protected]>
Co-authored-by: Prafulla Mahindrakar <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants