This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix container name logging #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 57 57
Lines 2424 2424
=======================================
Hits 1759 1759
Misses 527 527
Partials 138 138
Continue to review full report at Codecov.
|
|
@kumare3 Thanks! So nice to be back after a long break. |
EngHabu
pushed a commit
that referenced
this pull request
Mar 22, 2021
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
pushed a commit
that referenced
this pull request
Mar 22, 2021
Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
There is a missing parameter when logging, so container name is not logged.
Type
Are all requirements met?
Complete description
This is a minor fix that doesn't require design.
Tracking Issue
Follow-up issue