Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

incorporate latest boilerplate changes #53

Merged
merged 7 commits into from
Jan 24, 2020
Merged

incorporate latest boilerplate changes #53

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b18fd7b
incorporate latest boilerplate changes
honnix Jan 21, 2020
ea9a757
Update Makefile
honnix Jan 21, 2020
ce65baa
depend on download_tooling
honnix Jan 21, 2020
7507334
Merge branch 'update-boilerplate' of github.com:honnix/flytestdlib in…
honnix Jan 21, 2020
9333440
Revert "depend on download_tooling"
honnix Jan 21, 2020
e9dc8d9
comment
honnix Jan 21, 2020
f11b511
use latest boilerplate
honnix Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ compile:
mkdir -p ./bin
go build -o pflags ./cli/pflags/main.go && mv ./pflags ./bin

gen-config: download_tooling
gen-config:
which pflags || (go get github.com/lyft/flytestdlib/cli/pflags)
@go generate ./...

.PHONY: test_unit_codecov
Expand Down
1 change: 0 additions & 1 deletion boilerplate/lyft/golang_test_targets/download_tooling.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ go_install_tool () {
# List of tools to go get
# In the format of "<cli>:<package>" or ":<package>" if no cli
tools=(
"pflags:github.com/lyft/flytestdlib/cli/pflags"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work. I guess due to the funky dependency of itself.

"golangci-lint:github.com/golangci/golangci-lint/cmd/golangci-lint"
)

Expand Down