This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Rammer <[email protected]>
hamersaw
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
November 8, 2022 22:13
Signed-off-by: Dan Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
- Coverage 68.76% 68.12% -0.65%
==========================================
Files 69 69
Lines 3419 4075 +656
==========================================
+ Hits 2351 2776 +425
- Misses 909 1141 +232
+ Partials 159 158 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
EngHabu
reviewed
Nov 9, 2022
with: | ||
file: coverage.txt | ||
flags: unittests | ||
fail_ci_if_error: true | ||
fail_ci_if_error: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this ok?
EngHabu
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline. As long as this still fails code coverage percentage check, that's alright
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* disable codecov Signed-off-by: Dan Rammer <[email protected]> * bump codecov action verison Signed-off-by: Dan Rammer <[email protected]> Signed-off-by: Dan Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR allows the github worklow to succeed even if codecov upload fails.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA