Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Ignore codecov upload failures #144

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Nov 8, 2022

TL;DR

This PR allows the github worklow to succeed even if codecov upload fails.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Dan Rammer <[email protected]>
@hamersaw hamersaw changed the title Ignore codecov push failures Ignore codecov upload failures Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #144 (f0b9eff) into master (65025fd) will decrease coverage by 0.64%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   68.76%   68.12%   -0.65%     
==========================================
  Files          69       69              
  Lines        3419     4075     +656     
==========================================
+ Hits         2351     2776     +425     
- Misses        909     1141     +232     
+ Partials      159      158       -1     
Flag Coverage Δ
unittests 68.12% <75.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cache/auto_refresh.go 77.85% <ø> (+5.12%) ⬆️
cli/pflags/api/tag.go 77.41% <ø> (+0.14%) ⬆️
futures/future.go 100.00% <ø> (ø)
profutils/server.go 51.47% <0.00%> (-5.68%) ⬇️
promutils/labeled/stopwatch.go 81.63% <ø> (+1.63%) ⬆️
promutils/scope.go 87.60% <ø> (-0.69%) ⬇️
storage/copy_impl.go 79.48% <ø> (-0.52%) ⬇️
storage/storage.go 100.00% <ø> (ø)
utils/auto_refresh_cache.go 67.92% <ø> (-2.08%) ⬇️
storage/protobuf_store.go 71.42% <33.33%> (-6.84%) ⬇️
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

with:
file: coverage.txt
flags: unittests
fail_ci_if_error: true
fail_ci_if_error: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this ok?

Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. As long as this still fails code coverage percentage check, that's alright

@hamersaw hamersaw merged commit ab23187 into master Nov 14, 2022
@hamersaw hamersaw deleted the housekeeping/disable-codecov branch November 14, 2022 16:47
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* disable codecov

Signed-off-by: Dan Rammer <[email protected]>

* bump codecov action verison

Signed-off-by: Dan Rammer <[email protected]>

Signed-off-by: Dan Rammer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants