Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

codecov action version bump #143

Merged
merged 2 commits into from
Nov 7, 2022
Merged

codecov action version bump #143

merged 2 commits into from
Nov 7, 2022

Conversation

aliabbasjaffri
Copy link
Contributor

@aliabbasjaffri aliabbasjaffri commented Nov 3, 2022

Code coverage action is failing. It can be because we're using a deprecated version of codecov uploader bash script. I removed it and bumped up the version of codecov action to push the coverage report to codecov servers

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Refer to codecov github readme

Tracking Issue

NA

Follow-up issue

NA

@welcome
Copy link

welcome bot commented Nov 3, 2022

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #143 (88a25a8) into master (65025fd) will decrease coverage by 0.61%.
The diff coverage is 75.75%.

❗ Current head 88a25a8 differs from pull request most recent head 3d32731. Consider uploading reports for the commit 3d32731 to get more accurate results

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   68.76%   68.14%   -0.62%     
==========================================
  Files          69       69              
  Lines        3419     2838     -581     
==========================================
- Hits         2351     1934     -417     
+ Misses        909      748     -161     
+ Partials      159      156       -3     
Flag Coverage Δ
unittests 68.14% <75.75%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cache/auto_refresh.go 75.72% <ø> (+3.00%) ⬆️
cli/pflags/api/tag.go 76.19% <ø> (-1.09%) ⬇️
futures/future.go 100.00% <ø> (ø)
profutils/server.go 49.01% <0.00%> (-8.13%) ⬇️
promutils/labeled/stopwatch.go 77.14% <ø> (-2.86%) ⬇️
promutils/scope.go 87.56% <ø> (-0.73%) ⬇️
storage/copy_impl.go 77.77% <ø> (-2.23%) ⬇️
storage/protobuf_store.go 74.41% <0.00%> (-3.85%) ⬇️
storage/storage.go 100.00% <ø> (ø)
utils/auto_refresh_cache.go 66.66% <ø> (-3.34%) ⬇️
... and 73 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@hamersaw hamersaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary fix. Ideally, we would update the codecov action in all Flyte repositories and do this through the boilerplate repository, but as we are transitioning to a monorepo this requires a non-negligible amount of time that will soon be unecessary.

@hamersaw hamersaw merged commit 1736864 into master Nov 7, 2022
@welcome
Copy link

welcome bot commented Nov 7, 2022

Congrats on merging your first pull request! 🎉

@hamersaw hamersaw deleted the codecov-action-bump branch November 7, 2022 22:43
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Updated codecov action version to 3.1.1

Signed-off-by: Ali Abbas Jaffri <[email protected]>

* Removed codecov updater utility

Signed-off-by: Ali Abbas Jaffri <[email protected]>

Signed-off-by: Ali Abbas Jaffri <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants