-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 68.76% 68.14% -0.62%
==========================================
Files 69 69
Lines 3419 2838 -581
==========================================
- Hits 2351 1934 -417
+ Misses 909 748 -161
+ Partials 159 156 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ali Abbas Jaffri <[email protected]>
Signed-off-by: Ali Abbas Jaffri <[email protected]>
88a25a8
to
3d32731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary fix. Ideally, we would update the codecov action in all Flyte repositories and do this through the boilerplate repository, but as we are transitioning to a monorepo this requires a non-negligible amount of time that will soon be unecessary.
Congrats on merging your first pull request! 🎉 |
* Updated codecov action version to 3.1.1 Signed-off-by: Ali Abbas Jaffri <[email protected]> * Removed codecov updater utility Signed-off-by: Ali Abbas Jaffri <[email protected]> Signed-off-by: Ali Abbas Jaffri <[email protected]>
Code coverage action is failing. It can be because we're using a deprecated version of codecov uploader bash script. I removed it and bumped up the version of codecov action to push the coverage report to codecov servers
Type
Are all requirements met?
Complete description
Refer to codecov github readme
Tracking Issue
NA
Follow-up issue
NA