This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix RefreshConfig #139
Merged
Fix RefreshConfig #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iaroslav-ciupin <[email protected]>
iaroslav-ciupin
requested review from
EngHabu,
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 68.98% 68.99%
=======================================
Files 69 69
Lines 3418 3419 +1
=======================================
+ Hits 2358 2359 +1
Misses 902 902
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: iaroslav-ciupin <[email protected]>
katrogan
reviewed
Aug 16, 2022
katrogan
approved these changes
Aug 16, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Fix RefreshConfig * RefreshConfig unit test Signed-off-by: iaroslav-ciupin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iaroslav-ciupin [email protected]
TL;DR
Fix RefreshConfig by passing old metrics to a new instance.
Type
Are all requirements met?