This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Extract out data store metrics for re-usability #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
katrogan
reviewed
Aug 12, 2022
storage/rawstores.go
Outdated
| // NewDataStore creates a new Data Store with the supplied config. | ||
| func NewDataStore(cfg *Config, metricsScope promutils.Scope) (s *DataStore, err error) { | ||
| func NewDataStore(cfg *Config, metrics *DataStoreMetrics) (s *DataStore, err error) { |
There was a problem hiding this comment.
let's keep the constructor as is, but also add a method func (d *DataStore) RefreshConfig(cfg *Config) error that can re-use code defined in this constructor (this shared code can be pulled out to a separate private func for re-use)
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 68.75% 68.78% +0.03%
==========================================
Files 69 69
Lines 3405 3418 +13
==========================================
+ Hits 2341 2351 +10
- Misses 905 908 +3
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iaroslav-ciupin
requested review from
EngHabu,
kumare3 and
wild-endeavor
as code owners
Signed-off-by: iaroslav-ciupin <[email protected]>
Signed-off-by: iaroslav-ciupin <[email protected]>
iaroslav-ciupin
force-pushed
the
data-store-refactor-metrics
branch
from
3ee4bf3 to
0a019f9
Compare
|
Why do we need to do this? It seems it can already be reinitialized - pass a different scope |
Signed-off-by: iaroslav-ciupin <[email protected]>
iaroslav-ciupin
force-pushed
the
data-store-refactor-metrics
branch
from
9cbf247 to
b9fb011
Compare
katrogan
reviewed
Aug 15, 2022
Signed-off-by: iaroslav-ciupin <[email protected]>
katrogan
reviewed
Aug 16, 2022
Signed-off-by: iaroslav-ciupin <[email protected]>
katrogan
approved these changes
Aug 16, 2022
|
Congrats on merging your first pull request! 🎉 |
8 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Extract out data store metrics for re-usability and add RefreshConfig method to DataStore * Add some tests to improve coverage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adjust DataStore to allow initialising it multiple times during a single application run.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/