Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Adding utils for signal ID context #137

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

hamersaw
Copy link
Contributor

TL;DR

With the additional of the signal service in FlyteAdmin we may want to track metrics on a per-signal basis. To do this we need to set the signal ID on the context.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

flyteorg/flyte#208

Follow-up issue

NA

Signed-off-by: Daniel Rammer <[email protected]>
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #137 (6368b4f) into master (1279ea2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   68.75%   68.79%   +0.04%     
==========================================
  Files          69       69              
  Lines        3405     3407       +2     
==========================================
+ Hits         2341     2344       +3     
+ Misses        905      904       -1     
  Partials      159      159              
Flag Coverage Δ
unittests 67.66% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contextutils/context.go 82.08% <100.00%> (+0.55%) ⬆️
sets/generic_set.go 100.00% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1279ea2...6368b4f. Read the comment docs.

@hamersaw hamersaw merged commit 80d1624 into master Dec 2, 2022
@hamersaw hamersaw deleted the feature/add-signal-context branch December 2, 2022 21:58
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants