This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Create a separate stow Location for signed url #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
requested review from
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 69.09% 68.87% -0.23%
==========================================
Files 68 68
Lines 3343 3370 +27
==========================================
+ Hits 2310 2321 +11
- Misses 865 878 +13
- Partials 168 171 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Haytham Abuelfutuh <[email protected]>
wild-endeavor
approved these changes
Apr 6, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Create a separate stow Location for signed url Signed-off-by: Haytham Abuelfutuh <[email protected]> * Generate Signed-off-by: Haytham Abuelfutuh <[email protected]> * Revert ConnectionConfig deprecation for now Signed-off-by: Haytham Abuelfutuh <[email protected]> * updates Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update golden test files Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix unit test Signed-off-by: Haytham Abuelfutuh <[email protected]> * lint Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh [email protected]
TL;DR
Allow overriding storage config for SignedURL generation. This enables clients to use generate a signed url using a different endpoint that's externally accessible.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#2263