This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add PresignRequest API #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 68.21% 68.57% +0.35%
==========================================
Files 66 66
Lines 3250 3274 +24
==========================================
+ Hits 2217 2245 +28
+ Misses 865 863 -2
+ Partials 168 166 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
| }, false, testScope) | ||
| assert.NoError(t, err) | ||
|
|
||
| actual, err := s.CreateSignedURL(context.TODO(), DataReference("https://container/path"), SignedURLProperties{}) |
There was a problem hiding this comment.
i'm confused why this happy path starts with https://... shouldn't this be s3 or gcs?
There was a problem hiding this comment.
Any valid url format is ok.. no?
There was a problem hiding this comment.
i guess, i just find it confusing. would this ever be called like this?
|
oh this is great! we should move admin to use this for signed urls too once this is in |
Signed-off-by: Haytham Abuelfutuh <[email protected]>
katrogan
previously approved these changes
Mar 23, 2022
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
katrogan
previously approved these changes
Mar 23, 2022
Signed-off-by: Haytham Abuelfutuh <[email protected]>
wild-endeavor
approved these changes
Mar 24, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Add PresignRequest API Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit test and cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * more cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * More unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to latest stow commit Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update setup-go action Signed-off-by: Haytham Abuelfutuh <[email protected]> * update go Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update github actions Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update go version Signed-off-by: Haytham Abuelfutuh <[email protected]> * Pinning go to 1.17 Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update stow version to created release Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose PreSignRequest for storage clients
Signed-off-by: Haytham Abuelfutuh [email protected]
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#2263