Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Added go generate in workflow #111

Merged
merged 9 commits into from
Dec 28, 2021
Merged

Added go generate in workflow #111

merged 9 commits into from
Dec 28, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Dec 8, 2021

TL;DR

  • Added check for verify go-gen, it will fail if contributor forget to generate code

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#1872

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #111 (aa61529) into master (74a775b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   68.00%   67.97%   -0.04%     
==========================================
  Files          65       65              
  Lines        3216     3216              
==========================================
- Hits         2187     2186       -1     
- Misses        863      864       +1     
  Partials      166      166              
Flag Coverage Δ
unittests 66.57% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sets/generic_set.go 98.91% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a775b...aa61529. Read the comment docs.

Signed-off-by: Yuvraj <[email protected]>
@yindia
Copy link
Contributor Author

yindia commented Dec 20, 2021

@pmahindrakar-oss Need +1

Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia merged commit 7a05197 into master Dec 28, 2021
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Added go generate in workflow]
Signed-off-by: Yuvraj <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants