Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate FlyteSchema #942

Merged
merged 5 commits into from
Feb 14, 2023
Merged

Deprecate FlyteSchema #942

merged 5 commits into from
Feb 14, 2023

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jan 23, 2023

Signed-off-by: Kevin Su [email protected]

fixes: flyteorg/flyte#3278

image

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
# %%
# .. warning::
#
# ``FlyteSchema`` is deprecated, use :ref:`structured_dataset_example` instead.
Copy link
Contributor

@cosmicBboy cosmicBboy Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add back the version 1.4.0 and mention when this will be completely removed? I think we decided 12 releases from now, which probably means 1.16.0, unless we release 2.0.0 before that.

@cosmicBboy cosmicBboy enabled auto-merge (squash) February 14, 2023 17:14
@cosmicBboy cosmicBboy merged commit fb33975 into master Feb 14, 2023
@cosmicBboy cosmicBboy deleted the deprecate_schema branch February 14, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Deprecation messaging - Deprecate FlyteSchema 12 releases from now
2 participants