update configuring_links #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flyteorg/flyte#2820 Signed-off-by: SmritiSatyanV [email protected]
hamersaw
reviewed
Oct 3, 2022
| @@ -60,6 +60,23 @@ | |||
| - "https://some-other-source/home?region=us-east-1#logEventViewer:group=/flyte-production/kubernetes;stream=var.log.containers.{{.podName}}_{{.namespace}}_{{.containerName}}-{{.containerId}}.log" | |||
| messageFormat: "json" # "unknown" | "csv" | "json" | |||
|
|
|||
| .. tip:: | |||
| Since helm chart uses same templating for args (like ``{{ }}``), after compiling the chart, helm replaces flyte log link templates too. To avoid this, use escaped templating for flyte logs in the helm chart. | |||
There was a problem hiding this comment.
Suggested change
| Since helm chart uses same templating for args (like ``{{ }}``), after compiling the chart, helm replaces flyte log link templates too. To avoid this, use escaped templating for flyte logs in the helm chart. | |
| Since helm chart uses the same templating syntax for args (like ``{{ }}``) compiling the chart results in helm replacing Flyte log link templates as well. To avoid this, use escaped templating for Flyte logs in the helm chart. This will ensure that Flyte log link templates remain in place during helm chart compilation. |
Changes based on review Signed-off-by: SmritiSatyanV [email protected]
hamersaw
approved these changes
Oct 3, 2022
3t8
pushed a commit
to 3t8/flytesnacks
that referenced
this pull request
Oct 7, 2022
* update configuring_links Fixes flyteorg/flyte#2820 Signed-off-by: SmritiSatyanV [email protected] * update configuring links Changes based on review Signed-off-by: SmritiSatyanV [email protected] Signed-off-by: 3t8 <[email protected]>
3t8
pushed a commit
to 3t8/flytesnacks
that referenced
this pull request
Oct 7, 2022
* update configuring_links Fixes flyteorg/flyte#2820 Signed-off-by: SmritiSatyanV [email protected] * update configuring links Changes based on review Signed-off-by: SmritiSatyanV [email protected] Signed-off-by: 3t8 <[email protected]>
samhita-alla
added a commit
that referenced
this pull request
Oct 10, 2022
* Add blog post links in documentation Signed-off-by: 3t8 <[email protected]> * update configuring_links (#905) * update configuring_links Fixes flyteorg/flyte#2820 Signed-off-by: SmritiSatyanV [email protected] * update configuring links Changes based on review Signed-off-by: SmritiSatyanV [email protected] Signed-off-by: 3t8 <[email protected]> * Update map_task.py Signed-off-by: 3t8 <[email protected]> * Update cookbook/integrations/external_services/airflow/README.rst Co-authored-by: Samhita Alla <[email protected]> Signed-off-by: 3t8 <[email protected]> * Update README.rst Signed-off-by: 3t8 <[email protected]> * Update dynamics.py Signed-off-by: 3t8 <[email protected]> * Delete configure_logging_links.py Signed-off-by: 3t8 <[email protected]> * Revert "Delete configure_logging_links.py" This reverts commit 3fda83e. Restore configure_logging_links Signed-off-by: 3t8 <[email protected]> Signed-off-by: 3t8 <[email protected]> Co-authored-by: SmritiSatyanV <[email protected]> Co-authored-by: Samhita Alla <[email protected]>
ryankarlos
pushed a commit
to ryankarlos/flytesnacks
that referenced
this pull request
Oct 17, 2022
* Add blog post links in documentation Signed-off-by: 3t8 <[email protected]> * update configuring_links (flyteorg#905) * update configuring_links Fixes flyteorg/flyte#2820 Signed-off-by: SmritiSatyanV [email protected] * update configuring links Changes based on review Signed-off-by: SmritiSatyanV [email protected] Signed-off-by: 3t8 <[email protected]> * Update map_task.py Signed-off-by: 3t8 <[email protected]> * Update cookbook/integrations/external_services/airflow/README.rst Co-authored-by: Samhita Alla <[email protected]> Signed-off-by: 3t8 <[email protected]> * Update README.rst Signed-off-by: 3t8 <[email protected]> * Update dynamics.py Signed-off-by: 3t8 <[email protected]> * Delete configure_logging_links.py Signed-off-by: 3t8 <[email protected]> * Revert "Delete configure_logging_links.py" This reverts commit 3fda83e. Restore configure_logging_links Signed-off-by: 3t8 <[email protected]> Signed-off-by: 3t8 <[email protected]> Co-authored-by: SmritiSatyanV <[email protected]> Co-authored-by: Samhita Alla <[email protected]> Signed-off-by: Ryan Nazareth <[email protected]>
ryankarlos
pushed a commit
to ryankarlos/flytesnacks
that referenced
this pull request
Oct 17, 2022
* Add blog post links in documentation Signed-off-by: 3t8 <[email protected]> * update configuring_links (flyteorg#905) * update configuring_links Fixes flyteorg/flyte#2820 Signed-off-by: SmritiSatyanV [email protected] * update configuring links Changes based on review Signed-off-by: SmritiSatyanV [email protected] Signed-off-by: 3t8 <[email protected]> * Update map_task.py Signed-off-by: 3t8 <[email protected]> * Update cookbook/integrations/external_services/airflow/README.rst Co-authored-by: Samhita Alla <[email protected]> Signed-off-by: 3t8 <[email protected]> * Update README.rst Signed-off-by: 3t8 <[email protected]> * Update dynamics.py Signed-off-by: 3t8 <[email protected]> * Delete configure_logging_links.py Signed-off-by: 3t8 <[email protected]> * Revert "Delete configure_logging_links.py" This reverts commit 3fda83e. Restore configure_logging_links Signed-off-by: 3t8 <[email protected]> Signed-off-by: 3t8 <[email protected]> Co-authored-by: SmritiSatyanV <[email protected]> Co-authored-by: Samhita Alla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flyteorg/flyte#2820
Docs build: https://flyte--905.org.readthedocs.build/projects/cookbook/en/905/auto/deployment/configure_logging_links.html
Signed-off-by: SmritiSatyanV [email protected]