Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure mechanics in checkpoint example #894

Merged
merged 1 commit into from
Sep 24, 2022

Conversation

andrewwdye
Copy link
Contributor

@andrewwdye andrewwdye commented Sep 24, 2022

Signed-off-by: Andrew Dye [email protected]

TL;DR

The checkpoint example is not behaving correctly when n_iterations is not an exact multiple of RETRIES due to use of float. Fix the logic to choose a failure interval of n_iterations // RETRIES.

Testing

Verified running locally raises an exception on iteration (as expected) and that workflow succeeds when running with pyflyte run --remote checkpoint.py example --n_iterations 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants