Fix failure mechanics in checkpoint example #894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Dye [email protected]
TL;DR
The checkpoint example is not behaving correctly when
n_iterations
is not an exact multiple ofRETRIES
due to use of float. Fix the logic to choose a failure interval ofn_iterations // RETRIES
.Testing
Verified running locally raises an exception on iteration (as expected) and that workflow succeeds when running with
pyflyte run --remote checkpoint.py example --n_iterations 10
.