-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use slimmer version of flytekit #583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
reviewed
Jan 12, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
changed the title
[wip] Use slimmer version of flytekit
Use slimmer version of flytekit
Jan 12, 2022
eapolinario
approved these changes
Jan 12, 2022
SmritiSatyanV
pushed a commit
that referenced
this pull request
Jan 12, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
SmritiSatyanV
added a commit
that referenced
this pull request
Jan 12, 2022
This reverts commit 346c22f.
wild-endeavor
added a commit
that referenced
this pull request
Jan 13, 2022
This reverts commit 9993b98.
eapolinario
added a commit
that referenced
this pull request
Jan 13, 2022
This reverts commit 9993b98. Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Jan 13, 2022
* Revert "Only register core (#598)" This reverts commit e4be1f8. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Fix master (#597)" This reverts commit 503fd43. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Use slimmer version of flytekit (#583)" This reverts commit 9993b98. Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
SmritiSatyanV
pushed a commit
that referenced
this pull request
Jan 17, 2022
* Revert "Only register core (#598)" This reverts commit e4be1f8. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Fix master (#597)" This reverts commit 503fd43. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Use slimmer version of flytekit (#583)" This reverts commit 9993b98. Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
SmritiSatyanV
added a commit
that referenced
this pull request
Jan 17, 2022
This reverts commit 346c22f.
SmritiSatyanV
pushed a commit
that referenced
this pull request
Jan 17, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
SmritiSatyanV
pushed a commit
that referenced
this pull request
Jan 17, 2022
* Revert "Only register core (#598)" This reverts commit e4be1f8. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Fix master (#597)" This reverts commit 503fd43. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Use slimmer version of flytekit (#583)" This reverts commit 9993b98. Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
SmritiSatyanV
added a commit
that referenced
this pull request
Jan 17, 2022
This reverts commit 346c22f.
SmritiSatyanV
pushed a commit
that referenced
this pull request
Jan 17, 2022
* Revert "Only register core (#598)" This reverts commit e4be1f8. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Fix master (#597)" This reverts commit 503fd43. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Use slimmer version of flytekit (#583)" This reverts commit 9993b98. Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
SmritiSatyanV
added a commit
that referenced
this pull request
Jan 17, 2022
This reverts commit 346c22f.
pingsutw
pushed a commit
to pingsutw/flyte-monorepo
that referenced
this pull request
Apr 4, 2023
* Revert "Only register core (#598)" This reverts commit c70bf4c. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Fix master (#597)" This reverts commit 51e33d4. Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Use slimmer version of flytekit (#583)" This reverts commit 0a43a59. Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP that will get merged to master anyways because we need a release of it.
Will be cleaned up in a future PR.