Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bigquery example #521

Merged
merged 8 commits into from
Apr 11, 2022
Merged

Add bigquery example #521

merged 8 commits into from
Apr 11, 2022

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Dec 28, 2021

Signed-off-by: Kevin Su [email protected]

Add Bigquery example, Related to flyteorg/flyte#1776

image

image

image

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@kumare3
Copy link
Contributor

kumare3 commented Dec 29, 2021

cc @pradithya / @vglocus can you guys take a look and help review?


@workflow
def full_bigquery_wf(version: int):
return bigquery_task_templatized_query(version=version)
Copy link
Member

@pradithya pradithya Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the output type? I think it'll be interesting to demonstrate how to use the output in the sample.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type will be StructuredDataset. it's a new type introduced after flytekit v0.30.0b3 and is a superset of flyte schema.
It can transparently read different data sources from (BigQuery, S3,...) and convert result tables or parquet file to pd.Dataframe or pyarrow.Table.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for more detail, you can check flyteorg/flytekit#785

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradithya so we were going to use Flyte schema, but we have been working on a better representation for structureddatasets in general- dataframes, tensors

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@kumare3
Copy link
Contributor

kumare3 commented Feb 11, 2022

@pingsutw should we merge this?

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw
Copy link
Member Author

It's ready to be merged.

@pingsutw
Copy link
Member Author

cc @kumare3 @wild-endeavor @pradithya mind taking a look

@kumare3 kumare3 merged commit a2b462b into flyteorg:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants