Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the scheduled workflows examples to core #413

Merged
merged 4 commits into from
Sep 20, 2021

Conversation

pmahindrakar-oss
Copy link
Contributor

@pmahindrakar-oss pmahindrakar-oss commented Sep 16, 2021

Signed-off-by: Prafulla Mahindrakar [email protected]

Now that we support native scheduler in sandbox the existing scheduled workflows which used to run only in AWS environment can now be run in sandbox environment

Tested these changes by installing the sandbox using helm charts with scheduler enabled.

  • flytectl register file /Users/praful/flytesnacks/cookbook/core/_pb_output/* -d development -p flytesnacks --version v1
  • flytectl update launchplan -p flytesnacks -d development my_fixed_rate_lp --version v1 --activate
  • flytectl update launchplan -p flytesnacks -d development my_cron_scheduled_lp --version v1 --activate

Saw the schedules being triggered on a regular cadence based on the cron or fixed schedule

Docs available here : https://flyte--413.org.readthedocs.build/projects/cookbook/en/413/

Signed-off-by: Prafulla Mahindrakar <[email protected]>
@pmahindrakar-oss pmahindrakar-oss changed the title Moved the scheduled workflows examples to core WIP : Moved the scheduled workflows examples to core Sep 16, 2021
@@ -270,6 +271,7 @@ def __call__(self, filename):
gallery_dirs = [
"auto/core/flyte_basics",
"auto/core/control_flow",
"auto/core/scheduled_worflows",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you reach here, i think we will have to add it to the panels page? and use the clock icon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
@pmahindrakar-oss pmahindrakar-oss changed the title WIP : Moved the scheduled workflows examples to core Moved the scheduled workflows examples to core Sep 20, 2021
#
# Scheduling features require additional infrastructure to run, so these will have to be created and configured.
# Scheduling feature can be run using the flyte native scheduler which comes with flyte but if you intend to use the AWS scheduler then it require additional infrastructure to run, so these will have to be created and configured.The following sections are only required if you use AWS scheme for the scheduler. You can even run the flyte native scheduler on AWS though
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English needs revisiting

@kumare3
Copy link
Contributor

kumare3 commented Sep 20, 2021

@pmahindrakar-oss minor changes to docs and then +1

@kumare3 kumare3 self-requested a review September 20, 2021 22:33
@kumare3 kumare3 merged commit 451e463 into master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants