Assymmetric return values not supported by local execution #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ketan Umare <[email protected]>
wild-endeavor
approved these changes
Jul 8, 2021
| @@ -222,11 +224,11 @@ def nested_conditions(my_input: float) -> float: | |||
| # to be the subset of outputs that all then-nodes produce. In the following example, we call square() in one condition | |||
| # and call double in another. | |||
| @task | |||
| def sum_diff(a: float, b: float) -> (float, float): | |||
| def sum_diff(a: float, b: float) -> float: | |||
There was a problem hiding this comment.
can we change the name and the comment tho?
There was a problem hiding this comment.
i am fixing it quickly
EngHabu
pushed a commit
that referenced
this pull request
Jul 12, 2021
Signed-off-by: Ketan Umare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that asymmetric return values are not supported by flytekit. This is either a regression or the new check revealed a bug. This is only a problem for local execution. Remote works fine.
A reason why this was not noticed is because, the coin toss example is non deterministic. I have now added a seed to the random num generator and have 2 tests, one for each path.
Signed-off-by: Ketan Umare [email protected]