Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guide links #1753

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

neverett
Copy link
Contributor

Update links to contributing guides since those have moved.

Signed-off-by: nikki everett <[email protected]>
@neverett neverett self-assigned this Oct 14, 2024
@neverett neverett requested a review from ppiegaze as a code owner October 14, 2024 22:25
@eapolinario
Copy link
Collaborator

eapolinario commented Oct 15, 2024

We have this action Register example to sandbox marked as required for all PRs, but that entire CI job is skipped if we're only editing files under the docs directory.

Unfortunately the simple check in github to skip checks altogether is not enough if we want to decrease the "weight" of these docs-only changes. There are ways to skip specific steps (e.g. using https://github.com/dorny/paths-filter), but that complicates the workflow, so to unblock this PR I removed that action as required for the time being while we figure out how to incorporate this in the checks.yml gh workflow.

@eapolinario eapolinario enabled auto-merge (squash) October 15, 2024 16:01
@eapolinario eapolinario merged commit 1c55995 into master Oct 15, 2024
4 checks passed
@eapolinario eapolinario deleted the nikki/docs/update-links branch October 15, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants