-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PERIAN Job Platform Agent example #1746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions that you can accept as you see fit, but there are two changes you'll need to make to get the docs to build correctly and make tests pass:
- Update the LABEL format in the Dockerfile
- Add an entry to the
toctree
at the bottom of the integrations/index.md file
Thanks a lot for the suggestions @neverett. I've applied them all and also updated the example_template. |
@neverett My mistake. Just signed them off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. @otarabai could you help fix the merge conflict?
@otarabai one other thing -- could you add flytekit documentation for this agent? You will need to add a |
459dbaf
to
9433ade
Compare
Signed-off-by: Omar Tarabai <[email protected]>
...and fixed the lint error |
The PERIAN agent is already merged here.