Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Overhaul #1656

Merged
merged 47 commits into from
Apr 24, 2024
Merged

CI Overhaul #1656

merged 47 commits into from
Apr 24, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Apr 22, 2024

  • Speed up CI/CD pipeline by 20x
  • Use uv to install the packages
  • Remove requirements.txt since the majority of them are still using a pretty old flytekit (<1.0)
  • Build and push ImageSpec. (we didn't build imageSpec before)
  • Instead of serializing the example inside a Docker container, serialize it locally
  • Remove the push_example_image_to_github workflow since it hasn't been used anywhere. In addition, we're using ImageSpec in the flytesnacks example, so it doesn't make sense to build an image from the Dockerfile
  • Serailzie and register all the examples under examples folder.

Follow-up PR

  • Remove Dockerfile

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw added 22 commits April 23, 2024 07:55
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw added 13 commits April 23, 2024 17:59
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw changed the title [WIP] CI Overhaul CI Overhaul Apr 23, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
neverett
neverett previously approved these changes Apr 23, 2024
Signed-off-by: Kevin Su <[email protected]>
neverett
neverett previously approved these changes Apr 23, 2024
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw merged commit c302ec5 into master Apr 24, 2024
55 checks passed
@pingsutw pingsutw deleted the ci-overhaul branch April 24, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants