This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR adds real-time deck support.
Previously:
With this PR:
Why not only add deck URI to event when the URI exists?
Due to constraints within Propeller, we cannot determine if a user has enabled deck or when they will upload the deck.html to remote storage. Therefore, without constantly checking the existence of the URI at every reconciliation (which would be too costly), it's impossible to know when the URI becomes available.
More details
As node events are only sent when the node state changes, the only chance we have to send the deck URI with the event is when the state changes from 'Queued' to 'Running'. As explained above, it is not feasible to send additional events once the deck URI exists, as we cannot accurately determine when the URI will become available.
Checks and behaviors
real time deck support includes:
Type
Are all requirements met?