This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fixing recovering of SKIPPED nodes #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is executed Signed-off-by: Daniel Rammer <[email protected]>
wild-endeavor
approved these changes
Apr 7, 2023
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
… is executed (flyteorg#551) Signed-off-by: Daniel Rammer <[email protected]>
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The PR to enable recovering dynamic workflows when they have already compiled the workflow closure updated the node executor to always use the phase returned from
attemptRecovery. This surfaced an issue where nodes in theSKIPPEDphase were reported asSKIPPEDduring recovery when they should be executed in the recovered workflow.This PR correctly reports the phase of previously
SKIPPEDnodes asUNDEFINEDto ensure the nodes are correctly evaluated during workflow recoveries.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#3578
Follow-up issue
NA