Bump FlytePlugins version #469

pingsutw · 2022-08-09T18:12:54Z

Signed-off-by: Kevin Su [email protected]

TL;DR

Bump flyteplugins version to support ray tasks
Updated args in manager.Options{} since ClientBuilder is removed from the latest version of controller-runtime
Replace ConfigMapsResourceLock with ConfigMapsLeasesResourceLock since ConfigMapsResourceLock is removed

Type

Bug Fix
Feature
Plugin

Are all requirements met?

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#2641

Follow-up issue

NA

Signed-off-by: Kevin Su <[email protected]>

pkg/controller/executors/kube.go

cmd/controller/cmd/root.go

Signed-off-by: Kevin Su <[email protected]>

codecov · 2022-08-11T08:22:57Z

Codecov Report

Merging #469 (18d5dd5) into master (0fc2b9f) will not change coverage.
The diff coverage is 50.00%.

Signed-off-by: Kevin Su <[email protected]>

cmd/controller/cmd/root.go

cmd/controller/cmd/webhook.go

pkg/controller/nodes/task/k8s/plugin_manager.go

Signed-off-by: Kevin Su <[email protected]>

pkg/controller/executors/kube_test.go

Signed-off-by: Kevin Su <[email protected]>

wild-endeavor · 2022-08-12T23:42:41Z

@hamersaw do you know why this test runs for so long? is it supposed to take more than six hours?

hamersaw · 2022-08-13T14:31:00Z

@hamersaw do you know why this test runs for so long? is it supposed to take more than six hours?

@wild-endeavor looks like the codeQL check - looking into it.

Signed-off-by: Kevin Su <[email protected]>

This reverts commit 0ea7a9f.

Signed-off-by: Kevin Su <[email protected]>

honnix · 2022-10-17T09:33:12Z

pkg/leaderelection/leader_election.go

@@ -41,7 +41,7 @@ func NewResourceLock(corev1 v1.CoreV1Interface, coordinationV1 v12.CoordinationV
 	}

 	// Leader id, needs to be unique
-	return resourcelock.New(resourcelock.ConfigMapsResourceLock,
+	return resourcelock.New(resourcelock.ConfigMapsLeasesResourceLock,


I'm not entirely sure, but this change seems to require additional permissions:

apiGroups: - coordination.k8s.io resources: - leases verbs: ...

If so, this is a breaking change unfortunately.

In fact, this caused a failed deployment for us because we did not have this RBAC permission in place when upgrading to 1.2.0.

@honnix so sorry about not exposing this in the release notes, thanks for tracking it down - it will be added. Are these additional RBAC permissions an issue?

It looks like the ConfigMapLeasesResourceLock has been the default for a very long time and we should have migrated over sooner. Now support for ConfigMapResourceLock has been removed.

@hamersaw No worries. Just wanted to give you folks a heads-up. It was fairly easy to solve on our side and it is all good now.

* Bump FlytePlugins version Signed-off-by: Kevin Su <[email protected]> * use ZZZ_DeprecatedClusterName instead Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * go generate Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * update workflow name Signed-off-by: Kevin Su <[email protected]> * add comment Signed-off-by: Kevin Su <[email protected]> * Address comment Signed-off-by: Kevin Su <[email protected]> * fix test Signed-off-by: Kevin Su <[email protected]> * remove cluster name Signed-off-by: Kevin Su <[email protected]> * remove cluster name Signed-off-by: Kevin Su <[email protected]> * test Signed-off-by: Kevin Su <[email protected]> * test Signed-off-by: Kevin Su <[email protected]> * test Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * set timeout Signed-off-by: Kevin Su <[email protected]> * update viper Signed-off-by: Kevin Su <[email protected]> * Revert "update viper" This reverts commit 0ea7a9f. * ping viper 0.9.0 Signed-off-by: Kevin Su <[email protected]> * updated stdlib Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]>

Bump FlytePlugins version

b4b609a

Signed-off-by: Kevin Su <[email protected]>

pingsutw requested review from kumare3, EngHabu and hamersaw as code owners August 9, 2022 18:12

hamersaw reviewed Aug 9, 2022

View reviewed changes

pkg/controller/executors/kube.go Outdated Show resolved Hide resolved

cmd/controller/cmd/root.go Show resolved Hide resolved

pingsutw added 6 commits August 10, 2022 02:25

use ZZZ_DeprecatedClusterName instead

4f6a82b

Signed-off-by: Kevin Su <[email protected]>

Merged master

97bdd49

Signed-off-by: Kevin Su <[email protected]>

lint

1251d57

Signed-off-by: Kevin Su <[email protected]>

lint

bc9c7d1

Signed-off-by: Kevin Su <[email protected]>

go generate

f9c0571

Signed-off-by: Kevin Su <[email protected]>

fix tests

221c65c

Signed-off-by: Kevin Su <[email protected]>

pingsutw added 3 commits August 11, 2022 16:49

fix tests

4bd3c6a

Signed-off-by: Kevin Su <[email protected]>

update workflow name

cbeb019

Signed-off-by: Kevin Su <[email protected]>

add comment

f42307a

Signed-off-by: Kevin Su <[email protected]>

hamersaw reviewed Aug 12, 2022

View reviewed changes

cmd/controller/cmd/root.go Outdated Show resolved Hide resolved

hamersaw reviewed Aug 12, 2022

View reviewed changes

cmd/controller/cmd/webhook.go Outdated Show resolved Hide resolved

hamersaw reviewed Aug 12, 2022

View reviewed changes

pkg/controller/nodes/task/k8s/plugin_manager.go Outdated Show resolved Hide resolved

pingsutw added 2 commits August 12, 2022 20:20

Address comment

24c6323

Signed-off-by: Kevin Su <[email protected]>

fix test

c0751c7

Signed-off-by: Kevin Su <[email protected]>

hamersaw reviewed Aug 12, 2022

View reviewed changes

pkg/controller/executors/kube_test.go Outdated Show resolved Hide resolved

pingsutw added 2 commits August 13, 2022 02:09

remove cluster name

1439e07

Signed-off-by: Kevin Su <[email protected]>

remove cluster name

9202651

Signed-off-by: Kevin Su <[email protected]>

hamersaw self-requested a review August 12, 2022 18:13

hamersaw previously approved these changes Aug 12, 2022

View reviewed changes

pingsutw added 3 commits August 13, 2022 04:46

test

9813a20

Signed-off-by: Kevin Su <[email protected]>

test

ddfad57

Signed-off-by: Kevin Su <[email protected]>

test

e67909e

Signed-off-by: Kevin Su <[email protected]>

fix tests

835c39b

Signed-off-by: Kevin Su <[email protected]>

pingsutw dismissed hamersaw’s stale review via 835c39b August 13, 2022 16:31

pingsutw added 6 commits August 15, 2022 06:14

set timeout

c7600e2

Signed-off-by: Kevin Su <[email protected]>

update viper

0ea7a9f

Signed-off-by: Kevin Su <[email protected]>

Revert "update viper"

7c08cc6

This reverts commit 0ea7a9f.

ping viper 0.9.0

78014af

Signed-off-by: Kevin Su <[email protected]>

updated stdlib

b31b306

Signed-off-by: Kevin Su <[email protected]>

nit

18d5dd5

Signed-off-by: Kevin Su <[email protected]>

hamersaw self-requested a review August 15, 2022 16:52

hamersaw approved these changes Aug 15, 2022

View reviewed changes

pingsutw merged commit 4938905 into master Aug 15, 2022

pingsutw deleted the ray-job branch August 15, 2022 17:00

honnix reviewed Oct 17, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump FlytePlugins version #469

Bump FlytePlugins version #469

pingsutw commented Aug 9, 2022

codecov bot commented Aug 11, 2022 •

edited

Loading

wild-endeavor commented Aug 12, 2022

hamersaw commented Aug 13, 2022

honnix Oct 17, 2022

honnix Oct 17, 2022

hamersaw Oct 17, 2022

honnix Oct 17, 2022

Bump FlytePlugins version #469

Bump FlytePlugins version #469

Conversation

pingsutw commented Aug 9, 2022

TL;DR

Type

Are all requirements met?

Complete description

Tracking Issue

Follow-up issue

codecov bot commented Aug 11, 2022 • edited Loading

Codecov Report

wild-endeavor commented Aug 12, 2022

hamersaw commented Aug 13, 2022

honnix Oct 17, 2022

Choose a reason for hiding this comment

honnix Oct 17, 2022

Choose a reason for hiding this comment

hamersaw Oct 17, 2022

Choose a reason for hiding this comment

honnix Oct 17, 2022

Choose a reason for hiding this comment

codecov bot commented Aug 11, 2022 •

edited

Loading