This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Decks proposal #453
Merged
Decks proposal #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
EngHabu
force-pushed
the
decks-proposal
branch
4 times, most recently
from
9a94dd0 to
e14eb96
Compare
EngHabu
force-pushed
the
decks-proposal
branch
3 times, most recently
from
c6335aa to
5d9ccd9
Compare
Signed-off-by: Haytham Abuelfutuh <[email protected]>
hamersaw
previously approved these changes
Jun 22, 2022
pingsutw
reviewed
Jun 22, 2022
pingsutw
reviewed
Jun 22, 2022
pingsutw
reviewed
Jun 22, 2022
pkg/controller/nodes/task/handler.go
Outdated
| logger.Errorf(ctx, "Failed to check deck file existence. Error: %v", err) | ||
| return handler.UnknownTransition, regErrors.Wrapf(err, "failed to check existence of deck file") | ||
| } else if exists { | ||
| deckUriValue := tCtx.ow.GetDeckPath() |
There was a problem hiding this comment.
sorry, please correct me if I'm wrong.
I think it should be deckUriValue := r.GetDeckPath().
When cache hit, we copy literal to another bucket, but we didn't copy the deck file to new path (tCtx.ow.GetDeckPath()). As a result, deckURI here should point to the original path (r.GetDeckPath())
There was a problem hiding this comment.
Aha, excellent observation! will fix that
There was a problem hiding this comment.
Removed it completely as we discussed earlier... people, for now, can click to follow the original execution of that task to find/access the decks... for now... to properly fix this, I think we need to modify the OutputReader interface in flyteplugins, specifically the Read() method to return OutputMetadata struct and the deckpath can be a field there...
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
pingsutw
approved these changes
Jun 22, 2022
8 tasks
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Add deck_uri in NodeExecutionEvent Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * lint fix Signed-off-by: Kevin Su <[email protected]> * Updated idl Signed-off-by: Kevin Su <[email protected]> * wip Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * Fix tests Signed-off-by: Kevin Su <[email protected]> * Fix tests Signed-off-by: Kevin Su <[email protected]> * Fix tests Signed-off-by: Kevin Su <[email protected]> * Fix tests Signed-off-by: Kevin Su <[email protected]> * Fix tests Signed-off-by: Kevin Su <[email protected]> * Updated idl Signed-off-by: Kevin Su <[email protected]> * address comment Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * updates Signed-off-by: Kevin Su <[email protected]> * updates Signed-off-by: Kevin Su <[email protected]> * More cleanup Signed-off-by: Haytham Abuelfutuh <[email protected]> * lint Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR comments Signed-off-by: Haytham Abuelfutuh <[email protected]> * Unit tests Signed-off-by: Haytham Abuelfutuh <[email protected]> * lint Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Kevin Su <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add deck_uri in NodeExecutionEvent. This change was originally proposed in #443 but this is a modified (and simplified) implementation that only sends DeckUri for task nodes...
Blocked By
flyteorg/flyteplugins#272
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#2175