This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Compiler Enum Support and updated flyteidl #minor #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
katrogan
approved these changes
Jun 11, 2021
| return true | ||
| } | ||
| } | ||
| // If t is an enum, it can be created from a string as Enums as just constrained String aliases |
There was a problem hiding this comment.
is this a runtime error then if the string isn't a valid enum value?
There was a problem hiding this comment.
but our entry points will not allow bad values
There was a problem hiding this comment.
@katrogan thats actually a good point. Can we restrict this in flyteadmin? Where we construct the launchplan?
There was a problem hiding this comment.
shouldn't the launch plan have to reference the enum type to be valid?
EngHabu
reviewed
Jun 12, 2021
| @@ -33,6 +33,20 @@ func (t trivialChecker) CastsFrom(upstreamType *flyte.LiteralType) bool { | |||
| if isVoid(upstreamType) { | |||
| return true | |||
| } | |||
|
|
|||
| // If upstream is an enum, it can be consumed as a string downstream | |||
| if upstreamType.GetEnumType() != nil { | |||
There was a problem hiding this comment.
We should also add a check to the static binding to fail if the string isn't in the list...
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Support for ENUM types in flytecompiler and flytepropeller update to support it
Type
Are all requirements met?
Complete description
https://docs.google.com/document/d/1rf0hMKbPebJ7jGYpsTDAbJ4ka58KIKD7EgWAEBIH06Q/edit#
Tracking Issue
flyteorg/flyte#590
Follow-up issue
NA