This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Support GeneratedNameMaxLength property #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
force-pushed
the
generated_name_length
branch
from
3bcaf57 to
5340d24
Compare
EngHabu
reviewed
Mar 23, 2021
regadas
force-pushed
the
generated_name_length
branch
2 times, most recently
from
c59294e to
6fdd31f
Compare
kumare3
reviewed
Mar 24, 2021
| f := append(o.GetFinalizers(), finalizer) | ||
| o.SetFinalizers(f) | ||
| } | ||
| } | ||
|
|
||
| func (e *PluginManager) GetProperties() pluginsCore.PluginProperties { | ||
| return pluginsCore.PluginProperties{} | ||
| props := e.plugin.GetProperties() |
There was a problem hiding this comment.
why not just return e.plugin.GetProperties()?
There was a problem hiding this comment.
right, so in this case e.plugin is a k8s.Plugin and GetProperties here returns a k8s.PluginProperties which can contain properties that only make sense for k8s.
There was a problem hiding this comment.
aah oops, sorry missed that
Signed-off-by: Filipe Regadas <[email protected]>
Signed-off-by: Filipe Regadas <[email protected]>
Signed-off-by: Filipe Regadas <[email protected]>
regadas
force-pushed
the
generated_name_length
branch
from
bd04a3c to
df3774c
Compare
Signed-off-by: Filipe Regadas <[email protected]>
EngHabu
approved these changes
Mar 24, 2021
kumare3
approved these changes
Mar 24, 2021
8 tasks
kumare3
pushed a commit
that referenced
this pull request
May 25, 2021
* Support GeneratedNameMaxLength property Signed-off-by: Filipe Regadas <[email protected]> * Use pluginCore LoadPlugin Signed-off-by: Filipe Regadas <[email protected]> * Update flyteplugins to v0.5.40 Signed-off-by: Filipe Regadas <[email protected]> * Fix lint Signed-off-by: Filipe Regadas <[email protected]> Signed-off-by: Ketan Umare <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Support GeneratedNameMaxLength property Signed-off-by: Filipe Regadas <[email protected]> * Use pluginCore LoadPlugin Signed-off-by: Filipe Regadas <[email protected]> * Update flyteplugins to v0.5.40 Signed-off-by: Filipe Regadas <[email protected]> * Fix lint Signed-off-by: Filipe Regadas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of flyteorg/flyte#858. needs rebase after flyteorg/flyteplugins#167
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#858