This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Pass along enhanced task events. #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
commented
Mar 22, 2021
go.mod
Outdated
| github.com/flyteorg/flyteidl v0.18.20 | ||
| github.com/flyteorg/flyteplugins v0.5.38 | ||
| github.com/flyteorg/flyteidl v0.18.25 | ||
| github.com/flyteorg/flyteplugins v0.5.39-0.20210322202107-51b9713edaba |
There was a problem hiding this comment.
will update before merging
Signed-off-by: Katrina Rogan <[email protected]>
EngHabu
reviewed
Mar 22, 2021
| @@ -14,9 +14,9 @@ import ( | |||
| ) | |||
|
|
|||
| // A CompositeWorkQueue can be used in cases where the work is enqueued by two sources. It can be enqueued by either | |||
| // 1. Informer for the Primary Object itself. In case of FlytePropeller, this is the workflow object | |||
| // 1. Informer for the Primary Object itself. InputReader case of FlytePropeller, this is the workflow object | |||
There was a problem hiding this comment.
goland you're 2 clever
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
…o task-event++ Signed-off-by: Katrina Rogan <[email protected]>
katrogan
commented
Mar 23, 2021
go.mod
Outdated
| github.com/flyteorg/flyteidl v0.18.24 | ||
| github.com/flyteorg/flyteplugins v0.5.38 | ||
| github.com/flyteorg/flyteidl v0.18.25 | ||
| github.com/flyteorg/flyteplugins v0.5.39-0.20210323171635-da37ae79061e |
There was a problem hiding this comment.
will update before merging
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
|
@EngHabu mind taking another look? |
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
EngHabu
approved these changes
Mar 24, 2021
kumare3
pushed a commit
that referenced
this pull request
May 25, 2021
Signed-off-by: Ketan Umare <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds the following to TaskExecutionMetadata
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#325
Follow-up issue
NA