This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Unblock flyteplugins being pulled due to Security override #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anand Swaminathan <[email protected]>
Signed-off-by: Anand Swaminathan <[email protected]>
Signed-off-by: Anand Swaminathan <[email protected]>
anandswaminathan
force-pushed
the
security-override
branch
from
03c2e65 to
b627478
Compare
anandswaminathan
changed the title
|
cc @regadas |
kumare3
reviewed
Mar 18, 2021
| ServiceAccountName string `json:"serviceAccountName,omitempty" protobuf:"bytes,8,opt,name=serviceAccountName"` | ||
| // Security context fields to define privilege and access control settings | ||
| // +optional | ||
| SecurityContext core.SecurityContext `json:"securityContext,omitempty" protobuf:"bytes,12,rep,name=securityContext"` |
There was a problem hiding this comment.
you have to generate code, this will not work.
The deepcopy code has to be generated and to do so is really not easy at the moment
Steps:
- ensure the propeller code is checked out in
$GOPATH/github.com/flyteorg/flytepropeller - Uncomment https://github.com/flyteorg/flytepropeller/blob/master/hack/tools.go#L5
- make op_code_generate
Signed-off-by: Anand Swaminathan <[email protected]>
kumare3
reviewed
Mar 18, 2021
| @@ -549,7 +550,7 @@ func (in *NodeStatus) DeepCopyInto(out *NodeStatus) { | |||
| *out = (*in).DeepCopy() | |||
| } | |||
| if in.DataReferenceConstructor != nil { | |||
| out.DataReferenceConstructor = in.DataReferenceConstructor | |||
| out.DataReferenceConstructor = in.DataReferenceConstructor.DeepCopyReferenceConstructor() | |||
There was a problem hiding this comment.
this is not compiling right?
you might want to just revert this line, or add a DeepCopy that just returns self
Signed-off-by: Anand Swaminathan <[email protected]>
Signed-off-by: Anand Swaminathan <[email protected]>
kumare3
approved these changes
Mar 18, 2021
kumare3
pushed a commit
that referenced
this pull request
May 25, 2021
* Pull in FlytePlugins for Security Context fix Signed-off-by: Anand Swaminathan <[email protected]> Signed-off-by: Ketan Umare <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
) * Pull in FlytePlugins for Security Context fix Signed-off-by: Anand Swaminathan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in latest propeller and plumbs SecurityContext from the FlyteWorkflow. Does not ack TaskTemplate for now.
Fixes build and unblocks plugins pull.