This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add support for custom KubeClient #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
force-pushed
the
pluginmanager_kubeclient
branch
from
4e9ca5f to
845d3ed
Compare
kumare3
reviewed
Mar 2, 2021
regadas
force-pushed
the
pluginmanager_kubeclient
branch
2 times, most recently
from
8c50120 to
d3f3689
Compare
EngHabu
reviewed
Mar 5, 2021
kumare3
reviewed
Mar 17, 2021
|
Looks good to me, can you please rebase and also, fix the linter? |
regadas
force-pushed
the
pluginmanager_kubeclient
branch
3 times, most recently
from
df24874 to
6ab047f
Compare
|
Includes changes from #238 |
kumare3
reviewed
Mar 18, 2021
kumare3
reviewed
Mar 18, 2021
regadas
force-pushed
the
pluginmanager_kubeclient
branch
from
489dfef to
ee9ef44
Compare
kumare3
reviewed
Mar 18, 2021
kumare3
reviewed
Mar 18, 2021
kumare3
previously approved these changes
Mar 18, 2021
regadas
force-pushed
the
pluginmanager_kubeclient
branch
from
3813d10 to
90faaa9
Compare
Signed-off-by: Filipe Regadas <[email protected]>
Signed-off-by: Filipe Regadas <[email protected]>
Signed-off-by: Filipe Regadas <[email protected]>
Signed-off-by: Filipe Regadas <[email protected]>
Signed-off-by: Filipe Regadas <[email protected]>
Signed-off-by: Filipe Regadas <[email protected]>
Signed-off-by: Filipe Regadas <[email protected]>
regadas
force-pushed
the
pluginmanager_kubeclient
branch
from
90faaa9 to
b9f8f50
Compare
kumare3
approved these changes
Mar 19, 2021
kumare3
pushed a commit
that referenced
this pull request
May 25, 2021
* Add support for custom KubeClient Signed-off-by: Filipe Regadas <[email protected]> * Review and rebase Signed-off-by: Filipe Regadas <[email protected]> * Fix test Signed-off-by: Filipe Regadas <[email protected]> * Update and fix conditions Signed-off-by: Filipe Regadas <[email protected]> * fix typo Signed-off-by: Filipe Regadas <[email protected]> * Rework test Signed-off-by: Filipe Regadas <[email protected]> * rebase master Signed-off-by: Filipe Regadas <[email protected]> Signed-off-by: Ketan Umare <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Add support for custom KubeClient Signed-off-by: Filipe Regadas <[email protected]> * Review and rebase Signed-off-by: Filipe Regadas <[email protected]> * Fix test Signed-off-by: Filipe Regadas <[email protected]> * Update and fix conditions Signed-off-by: Filipe Regadas <[email protected]> * fix typo Signed-off-by: Filipe Regadas <[email protected]> * Rework test Signed-off-by: Filipe Regadas <[email protected]> * rebase master Signed-off-by: Filipe Regadas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial take on adding support for a custom KubeClient supplied by plugins. If
KubeClientis added for a remote cluster we need to ignoreOwnerReferences@kumare3 @EngHabu let me know what you think.
This will require flyteorg/flyteplugins#154 and then a
flytepluginsversion bumpType
Are all requirements met?
Tracking Issue
https://github.com/lyft/flyte/issues/