This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Raw output prefix #169
Merged
Raw output prefix #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2020 11:05
kumare3
reviewed
Jul 31, 2020
kumare3
reviewed
Jul 31, 2020
| c.metrics.InterruptedThresholdHit.Inc(ctx) | ||
| } | ||
|
|
||
| rawOutputPrefix := c.defaultDataSandbox | ||
| if executionContext.GetRawOutputDataConfig().RawOutputDataConfig != nil && executionContext.GetRawOutputDataConfig().OutputLocationPrefix != "" { |
There was a problem hiding this comment.
hmm why the 2 checks?
So node execution context is recursive, so for a node, it should always be parent node exec context + some stuff?
There was a problem hiding this comment.
Removed. But this meant I had to fix a bunch of unit tests.
|
Mostly looks good to me, let me just dive deeper into the actual node context creation part |
EngHabu
previously approved these changes
Aug 12, 2020
EngHabu
approved these changes
Aug 12, 2020
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* attempt to bring in IDL change, and add to workflow struct * go sum * changes * spelling * make generate * just use meta * unit tests * wip * wip * make goimports * wip * add comment in config.yaml * Revert local changes Co-authored-by: Haytham AbuelFutuh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read then delete
will be bumped. More details
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#211
Follow-up issue
NA