This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Workqueue should add items using a rate limiter #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
approved these changes
Jun 9, 2020
wild-endeavor
approved these changes
Jun 9, 2020
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Everytime the object is re-enqueued to be processed, (in the K8s controller workqueue) it should be rate limited using any prior known conditions. For example, if a failure backoff is in effect it should be backed off, or if the bucketing is in effect, then the object should be throttled.
Type
Are all requirements met?
Complete description
Using the RateLimitingInterface => https://godoc.org/k8s.io/client-go/util/workqueue#RateLimitingInterface method - AddRateLimited
Tracking Issue
flyteorg/flyte#309
Follow-up issue
NA