This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
bug; aborted workflows bubble up the error and stay in running #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
reviewed
Jun 8, 2020
EngHabu
previously approved these changes
Jun 8, 2020
EngHabu
reviewed
Jun 9, 2020
EngHabu
approved these changes
Jun 9, 2020
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
* Update propeller * cleanup
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
…org#149) * Fix aborted workflows * Added more tests * Workflow aborted msg
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Abort can be initiated in 2 cases. Abort method now handles both the cases.
Case 1: User initiated. All retries are taken up
Case 2: System failure, atleast one retry is now available
Type
Are all requirements met?
Complete description
NA
Tracking Issue
flyteorg/flyte#309
Follow-up issue
NA