Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

feature; Capped retries for all failures and allowing backoff queue #146

Merged
merged 2 commits into from
Jun 6, 2020

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Jun 5, 2020

TL;DR

  • Currently if abort fails, workflow will not be retried. this PR makes it behave like other system errors
  • Abort failures are counted as system failures
  • System errors now get bubbled to the queue and we can have failure backoff strategies

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

flyteorg/flyte#309

Follow-up issue

NA

@kumare3 kumare3 requested a review from EngHabu as a code owner June 5, 2020 20:41
@codecov-commenter
Copy link

Codecov Report

Merging #146 into master will increase coverage by 0.06%.
The diff coverage is 86.66%.

@kumare3 kumare3 merged commit 4aea719 into master Jun 6, 2020
kumare3 pushed a commit to nuclyde-io/flytepropeller that referenced this pull request Feb 4, 2021
eapolinario pushed a commit to eapolinario/flytepropeller that referenced this pull request Aug 9, 2023
…lyteorg#146)

* Capped retries for all failures and allowing backoff queue

* lint fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants