This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Current level gauge for FlyteWorkflows #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
commented
May 15, 2020
EngHabu
previously approved these changes
May 15, 2020
Co-authored-by: Haytham AbuelFutuh <[email protected]>
wild-endeavor
changed the title
added 2 commits
May 15, 2020 18:36
EngHabu
approved these changes
May 18, 2020
| "github.com/lyft/flytepropeller/pkg/controller/nodes" | ||
| "github.com/lyft/flytepropeller/pkg/controller/nodes/subworkflow/launchplan" | ||
| "github.com/lyft/flytepropeller/pkg/controller/workflow" | ||
| ) | ||
|
|
||
| const resourceLevelMonitorCycleDuration = 5 * time.Second | ||
| const missing = "missing" |
There was a problem hiding this comment.
:D nit: missingProject ? or something descriptive
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
First in a long series of work around Propeller observability and system observability as a whole. Refer to the GH issue for more information.
Type
Are all requirements met?
Complete description
NodePort.Tracking Issue
flyteorg/flyte#311
Follow-up issue
NA