Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add project/domain to context for metric labeling #130

Merged
merged 3 commits into from
May 12, 2020

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented May 11, 2020

TL;DR

Add project/domain to context for metric labeling.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added this line of code

ctx = contextutils.WithProjectDomain(ctx, wfDeepCopy.GetExecutionID().Project, wfDeepCopy.GetExecutionID().Domain)

Tracking Issue

NA

Follow-up issue

NA

EngHabu
EngHabu previously approved these changes May 11, 2020
pkg/controller/handler.go Outdated Show resolved Hide resolved
EngHabu
EngHabu previously approved these changes May 11, 2020
@wild-endeavor wild-endeavor changed the title add project/domain to context for metric labeling Add project/domain to context for metric labeling May 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #130 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@wild-endeavor wild-endeavor merged commit c2883b0 into master May 12, 2020
kumare3 pushed a commit to nuclyde-io/flytepropeller that referenced this pull request Feb 4, 2021
eapolinario pushed a commit to eapolinario/flytepropeller that referenced this pull request Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants