This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Improving unit test coverage for simpler cases #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
approved these changes
Apr 19, 2020
There was a problem hiding this comment.
Approving. I'm personally okay with lower test coverage. Sure, referentially transparent functions should have unit tests, but I feel like none of the issues we've seen recently would've been caught by any of these tests. They would've probably benefited more from better integration testing and better staging-traffic live testing, load testing, etc. so I wonder if our time isn't better spent in those areas. Oftentimes I feel like I'm forced to write inane unit tests just to get the numbers up.
|
@wild-endeavor unit tests are not always for protecting large problems in systems, IMO they serve 2 purposes
|
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
In case there is no override in resource table, we should allow the code to go through and apply non-label based weighted random selection. Close flyteorg/flyte#481
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
We want to drive overall unit test coverage. Following this checkin we will enforce strict coverage gates
Type
Are all requirements met?
Complete description
Tracking Issue
NA
Follow-up issue
NA