This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Restrict review access and commit access to few engineers #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 50.44% 50.44%
=======================================
Files 128 128
Lines 7997 7997
=======================================
Hits 4034 4034
Misses 3572 3572
Partials 391 391 Continue to review full report at Codecov.
|
wild-endeavor
approved these changes
Apr 16, 2020
haha, yes, sorry about that. We will expand this set slowly |
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
Co-authored-by: Konstantin Gizdarski <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently Flytepropeller allows anyone at Lyft to approve a code change. This can be detrimental and users should consult some people who have more understanding of the codebase
Type
Are all requirements met?
Complete description
NA
Tracking Issue
NA
Follow-up issue
NA