This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix exponent overflow #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if a lock is really needed in backoff handler because the race condition should be benign (increment and reset to 0 only). But if we don't see much performance hit we can keep it just to be safe. |
bnsblue
previously approved these changes
Mar 31, 2020
kumare3
reviewed
Mar 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 49.82% 49.94% +0.11%
==========================================
Files 127 127
Lines 7970 7959 -11
==========================================
+ Hits 3971 3975 +4
+ Misses 3611 3596 -15
Partials 388 388
Continue to review full report at Codecov.
|
kumare3
previously approved these changes
Mar 31, 2020
bnsblue
approved these changes
Mar 31, 2020
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Backoff controller has two issues: 1) backoff() can overflow the exponent value leading to 0 backoff duration all the time. 2) There is a race condition in updating fields of the simple backoff handler. this PR should address both.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Backoff controller has two issues: 1) backoff() can overflow the exponent value leading to 0 backoff duration all the time. 2) There is a race condition in updating fields of the simple backoff handler. this PR should address both.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#233