Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Commit

Permalink
Clean up commented code
Browse files Browse the repository at this point in the history
Signed-off-by: Haytham Abuelfutuh <[email protected]>
  • Loading branch information
EngHabu committed Jun 2, 2021
1 parent 0d03bf2 commit 23388b9
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions pkg/compiler/workflow_compiler.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,28 +213,6 @@ func (w workflowBuilder) ValidateWorkflow(fg *flyteWorkflow, errs errors.Compile
}
}

// At this point, all nodes except branch nodes have populated all their input and output interfaces,
// Because conditions in branch nodes do not carry type information with them for the variables involved (e.g.
// if x == y), we need to wait till all nodes have populated their interfaces before we can resolve x and y to their
// original types and then validate whether they are compatible for comparison.
//if !errs.HasErrors() {
// for _, n := range wf.Nodes {
// if n.GetBranchNode() != nil {
// if inputVars, ok := v.ValidateBindings(&wf, n, n.GetInputs(), n.GetInterface().GetInputs(),
// false /* validateParamTypes */, c.EdgeDirectionUpstream, errs.NewScope()); ok {
// merge, err := v.UnionDistinctVariableMaps(n.GetInterface().Inputs.Variables, inputVars.Variables)
// if err != nil {
// errs.Collect(errors.NewWorkflowBuildError(err))
// }
//
// n.GetInterface().Inputs = &core.VariableMap{Variables: merge}
//
// v.ValidateBranchNode(&wf, n, true /* validateConditionTypes */, errs.NewScope())
// }
// }
// }
//}

// Add explicitly and implicitly declared edges
for nodeID, n := range wf.Nodes {
if nodeID == c.StartNodeID {
Expand Down

0 comments on commit 23388b9

Please sign in to comment.