Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Allow multiple arguments to be substituted in one run #92

Merged
merged 4 commits into from
May 26, 2020

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented May 26, 2020

TL;DR

A query like

     SELECT
        	COUNT(*) as total_count
    	FROM
        	hive.events.{{ .Inputs.table }}
    	WHERE
        	ds = '{{ .Inputs.ds }}' AND hr = {{ .Inputs.hr }} AND min = {{ .Inputs.min }}

should be substituted.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#320

Follow-up issue

flyteorg/flyte#321

@kumare3 kumare3 requested a review from EngHabu May 26, 2020 22:43
EngHabu
EngHabu previously approved these changes May 26, 2020
@kumare3 kumare3 dismissed stale reviews from wild-endeavor and EngHabu via dde2a0d May 26, 2020 23:00
EngHabu
EngHabu previously approved these changes May 26, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #92 into master will increase coverage by 0.35%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   55.00%   55.35%   +0.35%     
==========================================
  Files          91       92       +1     
  Lines        4663     4666       +3     
==========================================
+ Hits         2565     2583      +18     
+ Misses       1821     1809      -12     
+ Partials      277      274       -3     
Impacted Files Coverage Δ
go/tasks/pluginmachinery/utils/template.go 71.25% <86.36%> (+9.05%) ⬆️
go/tasks/pluginmachinery/utils/error_collection.go 100.00% <100.00%> (ø)
go/tasks/pluginmachinery/utils/transformers.go 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e2087...847b54b. Read the comment docs.

@kumare3 kumare3 merged commit 502fafe into master May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants